Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indirect vulnerabilities by bumping minder and protobuf #259

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Fix indirect vulnerabilities by bumping minder and protobuf #259

merged 2 commits into from
Jan 8, 2025

Conversation

rdimitrov
Copy link
Member

The following PR bumps direct dependencies which should resolve 1 dependabot-raised vulnerability.

@rdimitrov rdimitrov requested a review from a team as a code owner January 8, 2025 12:05
@rdimitrov rdimitrov self-assigned this Jan 8, 2025
@eleftherias
Copy link
Contributor

Weirdly the workflow looks like it's passing, but the test job is actually fails with ./rules_test.go:150:51: not enough arguments in call to rtengine.NewRuleTypeEngine

@rdimitrov
Copy link
Member Author

Weirdly the workflow looks like it's passing, but the test job is actually fails with ./rules_test.go:150:51: not enough arguments in call to rtengine.NewRuleTypeEngine

Thanks for noticing this, fixed it! 👍

@rdimitrov rdimitrov merged commit cbcd86c into main Jan 8, 2025
6 checks passed
@rdimitrov rdimitrov deleted the fix-vulns branch January 8, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias eleftherias approved these changes

Assignees

@rdimitrov rdimitrov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdimitrov @eleftherias